Fixed assignment of proxies in KiotaRequestAdapter for HTTPX 0.28.x compliancy #45741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
dabla
changed the title
dabla
changed the title
potiuk
approved these changes
Jan 17, 2025
dauinh
pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
…rHook (apache#45741) Co-authored-by: David Blain <[email protected]>
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…rHook (apache#45741) Co-authored-by: David Blain <[email protected]>
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
…rHook (apache#45741) Co-authored-by: David Blain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR #45464 did some changes to be HTTPX 0.28.x, unfortunately it broke the parametrization of the proxies parameter, this is fixed in this PR.
As the proxies parameter is deprecated in HTTPX 0.27.x and is removed in 0.28.x, it was wrongly assigned to the mounts parameter, it should in fact be assigned to the proxy parameter, this PR fixes it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.